Merged
Conversation
WallyMaier
approved these changes
Jan 17, 2021
Contributor
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
@pcarruscag thanks for going through this! MSW is not definitely not the greatest scheme, but is used alot in hypersonics (since its so dissapative).
This looks good to me!
WallyMaier
reviewed
Jan 17, 2021
|
|
||
| /*--- Compute gradient for MUSCL reconstruction, for output (i.e. the | ||
| turbulence solver) only density and velocity are needed ---*/ | ||
| turbulence solver, and post) only temperature and velocity are needed ---*/ |
Contributor
There was a problem hiding this comment.
Is post referring to post-processing?
Member
Author
There was a problem hiding this comment.
yes, I did not write "processing" because the 2 lines lined up with just post
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Leaks and stuff, @WallyMaier I did not check if the method is implemented correctly, looked decent on the naca0012.
Related Work
fix #1161
PR Checklist